@@ -269,6 +269,57 @@ def test_response_mode_form_post(test_client):
269269 assert b'name="state"' in rv .data
270270
271271
272+ @pytest .mark .parametrize (
273+ "redirect_uri" ,
274+ [
275+ "javascript://client.test/%0Aalert(1)" ,
276+ "JavaScript://client.test/\n alert(1)" ,
277+ "com.example.app://client.test/callback" ,
278+ ],
279+ )
280+ @pytest .mark .parametrize ("user_id" , ["1" , None ])
281+ @pytest .mark .parametrize ("default_response_mode" , [False , True ])
282+ def test_response_mode_form_post_non_http_redirect_uri (
283+ test_client , db , client , monkeypatch , redirect_uri , user_id , default_response_mode
284+ ):
285+ """A form_post response must not target a non-HTTP redirect URI.
286+
287+ The request is refused before any form is rendered, whether the user
288+ approves or denies the authorization.
289+ """
290+ client .set_client_metadata (
291+ {
292+ "redirect_uris" : [redirect_uri ],
293+ "scope" : "openid profile" ,
294+ "token_endpoint_auth_method" : "none" ,
295+ "response_types" : ["id_token" , "id_token token" ],
296+ "id_token_signed_response_alg" : "HS256" ,
297+ }
298+ )
299+ db .session .add (client )
300+ db .session .commit ()
301+
302+ data = {
303+ "response_type" : "id_token" ,
304+ "response_mode" : "form_post" ,
305+ "client_id" : "client-id" ,
306+ "scope" : "openid profile" ,
307+ "state" : "bar" ,
308+ "nonce" : "abc" ,
309+ "redirect_uri" : redirect_uri ,
310+ }
311+ if user_id :
312+ data ["user_id" ] = user_id
313+ if default_response_mode :
314+ monkeypatch .setattr (_OpenIDImplicitGrant , "DEFAULT_RESPONSE_MODE" , "form_post" )
315+ del data ["response_mode" ]
316+ rv = test_client .post ("/oauth/authorize" , data = data )
317+ assert rv .status_code == 400
318+ assert rv .json ["error" ] == "invalid_request"
319+ assert rv .location is None
320+ assert b"<form" not in rv .data
321+
322+
272323def test_client_metadata_custom_alg (test_client , app , db , client ):
273324 """If the client metadata 'id_token_signed_response_alg' is defined,
274325 it should be used to sign id_tokens."""
0 commit comments