Skip to content
This repository was archived by the owner on Sep 25, 2025. It is now read-only.

Fix publishing#23

Merged
jimmyjames merged 2 commits intoauth0:masterfrom
jsalinaspolo:fix-publishing
Nov 18, 2020
Merged

Fix publishing#23
jimmyjames merged 2 commits intoauth0:masterfrom
jsalinaspolo:fix-publishing

Conversation

@jsalinaspolo
Copy link
Copy Markdown
Contributor

@jsalinaspolo jsalinaspolo commented Nov 17, 2020

Description

Fix publish artifacts by using default project name, version, group defined in the project

Reference

Use defaults
https://docs.gradle.org/current/userguide/publishing_maven.html#sec:identity_values_in_the_generated_pom

Testing

Publish locally the gradle plugin and publish locally auth-java using the fix

@jsalinaspolo jsalinaspolo requested a review from a team as a code owner November 17, 2020 11:18
@jimmyjames
Copy link
Copy Markdown
Contributor

Thanks Javier. Looks good to me (did publish to my local maven with these changes), but @lbalmaceda should approve as the maintainer, as well as identify any changes that may be needed to the Auth0.Android repo to publish using this version, once released.

Copy link
Copy Markdown
Contributor

@jimmyjames jimmyjames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed together with @lbalmaceda. 👍

@jimmyjames jimmyjames merged commit 400f22c into auth0:master Nov 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants