chore: update lru-memoizer to v3#476
Conversation
|
@isidrok The only concern I have is around node versions supported by lru-cache@11. At the moment, I don’t see any issues, our CI is passing on Node 14, 16, and 18, and nothing appears to be breaking. However, this does seems to introduce a real future risk. Patch releases of lru-cache@11 could start relying on newer Node APIs that aren’t available in older Node versions, which could lead to unexpected breakage for users. Additionally, some environments enforce strict engine checks, which could cause CI or installs to fail even if the code itself still works. |
|
Hi @cschetan77 that makes sense, but given that Node 20 is already in maintenance mode and the active LTS is 24, maybe consider dropping support for older versions and create a new major version of this library focusing on Node 20+ |
|
@isidrok I agree. We’re evaluating the trade-offs carefully and will take a decision soon. |
isidrok
force-pushed
the
feature/update-lru-memoizer-v2
branch
from
f6936c7 to
e11b943
Compare
|
LGTM |
2 participants
By submitting a PR to this repository, you agree to the terms within the Auth0 Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.
Description
This library is using an outdated version of lru-memoizer, which in turn has a dependency on lru-cache. The lru-cache version it is using is pretty outdated and is no longer compatible with new versions, as a result applications depending on packages that use different versions break when bundling them.
References
Fixes #424
Testing
This should be covered by existing tests
Checklist