[major] bump jose#333
Merged
adamjmcgrath merged 5 commits intoauth0:masterfrom Nov 1, 2022
panva:bump-jose
Merged
Conversation
russellwhitaker
previously approved these changes
Oct 24, 2022
|
This looks good @panva , do you expect it might be officially approved by the team and merged soon, with an npm artifact? |
Member
Author
|
any updates on this one? |
adamjmcgrath
reviewed
Nov 1, 2022
adamjmcgrath
reviewed
Nov 1, 2022
adamjmcgrath
reviewed
Nov 1, 2022
Contributor
adamjmcgrath
left a comment
adamjmcgrath
left a comment
There was a problem hiding this comment.
circleci/node:18 isn't available, switching to cimg/node
adamjmcgrath
approved these changes
Nov 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This bumps the major version of
joseto the latest one released.This is a major version bump and i'd recommend an engines update to go along with a release that allows lts/14, lts/16, lts/18 and >=19, that is all currently active or maintained LTS releases and current and future current/lts releases as per https://github.com/nodejs/Release.