Skip to content

Fix GetVerificationKey typing to include undefined#329

Merged
adamjmcgrath merged 2 commits intoauth0:masterfrom
AaronMoat:fix-express-jwt-secret-typing
Oct 10, 2022
Merged

Fix GetVerificationKey typing to include undefined#329
adamjmcgrath merged 2 commits intoauth0:masterfrom
AaronMoat:fix-express-jwt-secret-typing

Conversation

@AaronMoat
Copy link
Copy Markdown
Contributor

@AaronMoat AaronMoat commented Oct 10, 2022

Description

Update GetVerificationKey type to reflect reality

References

Resolves #328

Testing

None so far - does this deserve a test? tests/ts-definitions.tests.ts is pretty lightweight so far.

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs I don't think this is required.
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not the default branch

@AaronMoat AaronMoat requested a review from a team as a code owner October 10, 2022 06:44
Copy link
Copy Markdown
Contributor

@adamjmcgrath adamjmcgrath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AaronMoat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

expressJwtSecret can return undefined which is not reflected in GetVerificationKey type

2 participants