Skip to content

Type definitions depend on jsonwebtoken#314

Merged
adamjmcgrath merged 1 commit intomasterfrom
jsonwebtoken-dep
Jun 7, 2022
Merged

Type definitions depend on jsonwebtoken#314
adamjmcgrath merged 1 commit intomasterfrom
jsonwebtoken-dep

Conversation

@adamjmcgrath
Copy link
Copy Markdown
Contributor

Description

The ts def file depends on jsonwebtoken so the type deps should be included in the dependencies (like express)

References

fixes #312

@adamjmcgrath adamjmcgrath added the review:tiny Tiny review label Jun 7, 2022
@adamjmcgrath adamjmcgrath requested a review from a team as a code owner June 7, 2022 14:30
@adamjmcgrath adamjmcgrath merged commit 995dbdb into master Jun 7, 2022
@adamjmcgrath adamjmcgrath deleted the jsonwebtoken-dep branch June 7, 2022 16:27
@adamjmcgrath adamjmcgrath mentioned this pull request Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review:tiny Tiny review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Typescript compilation fails on v2.1.1+ due to missing jsonwebtoken types

2 participants