Skip to content

add support for express-jwt@7#297

Merged
adamjmcgrath merged 2 commits intoauth0:masterfrom
jfromaniello:express_jwt_7
Apr 26, 2022
Merged

add support for express-jwt@7#297
adamjmcgrath merged 2 commits intoauth0:masterfrom
jfromaniello:express_jwt_7

Conversation

@jfromaniello
Copy link
Copy Markdown
Member

Description

I changed the signature of express-jwt in version 7. This change makes node-jwks-rsa compatible with v6 and v7.

References

auth0/express-jwt#281

Testing

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@jfromaniello
Copy link
Copy Markdown
Member Author

This address issue #296

package.json Outdated
"dependencies": {
"@types/express-jwt": "0.0.42",
"debug": "^4.3.4",
"express-jwt-v7": "npm:express-jwt@^7.5.0",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should go in devDependencies

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch! fixed

@adamjmcgrath adamjmcgrath merged commit f43bea1 into auth0:master Apr 26, 2022
@adamjmcgrath
Copy link
Copy Markdown
Contributor

Thanks @jfromaniello! Will publish a release shortly

@jfromaniello jfromaniello deleted the express_jwt_7 branch April 26, 2022 14:21
@jfromaniello
Copy link
Copy Markdown
Member Author

awesome!

@adamjmcgrath adamjmcgrath mentioned this pull request Apr 26, 2022
@jfromaniello jfromaniello mentioned this pull request Jun 19, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants