Skip to content

Some fixes to token decoding#639

Closed
jsumners wants to merge 1 commit intoauth0:masterfrom
jsumners:decode-fixes
Closed

Some fixes to token decoding#639
jsumners wants to merge 1 commit intoauth0:masterfrom
jsumners:decode-fixes

Conversation

@jsumners
Copy link
Copy Markdown

@jsumners jsumners commented Oct 11, 2019

Description

This PR tweaks a couple of items in the decoding of web tokens.

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@panva
Copy link
Copy Markdown
Member

panva commented Oct 21, 2019

@jsumners the change is lacking test coverage and also, can you provide more background the change in general?

@jsumners
Copy link
Copy Markdown
Author

I suppose a direct test for checking if isObject picks up [] or 42 could exercise this PR. But it'd ultimately be checking a well known JavaScript pattern so I don't see much utility in it. Otherwise, I would hope the existing test suite already covers this.

More background would require using a webform and process I don't want to deal with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants