Reduce size of NPM package#347
Merged
ziluvatar merged 1 commit intoauth0:masterfrom Sep 6, 2017
Merged
Conversation
|
👍 |
Contributor
|
Nice! LGTM. |
Contributor
Author
|
I never realized that the changelog was kept as well, thanks for pointing that out! |
|
If possible, please update the Joi dependency because they had this same issue. The version that this module uses (6.10.1) has a package size of 703 kB and the current Joi version (10.6.0) has 166,9 kB. |
Contributor
Author
|
Thanks for merging! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change removes the following files/directories:
The lib directory, decode.js, sign.js and verify.js are kept explicitly, README.md, package.json, LICENSE and index.js are kept implicitly.
If you want to keep some of the above files please let me know and I update the PR.