Skip to content

update joi dependency#301

Closed
wao813 wants to merge 1 commit intoauth0:masterfrom
wao813:wao813-patch-1
Closed

update joi dependency#301
wao813 wants to merge 1 commit intoauth0:masterfrom
wao813:wao813-patch-1

Conversation

@wao813
Copy link
Copy Markdown

@wao813 wao813 commented Jan 24, 2017

The joi version in project is too old. Causing error for projects uses it with newer version.

@ziluvatar
Copy link
Copy Markdown
Contributor

ziluvatar commented Feb 3, 2017

The v10 brought problems for ES5 compatibility 51d4796
Not sure about the v8 though.

@zvictor
Copy link
Copy Markdown

zvictor commented Feb 10, 2017

right now, installing jsonwebtoken installs joi indirectly and consequently moment.js because of hapijs/joi#985.

my app becomes significantly heavier for no reasonable reason.

@ziluvatar
Copy link
Copy Markdown
Contributor

ziluvatar commented Feb 22, 2017

After a some investigation, any upgrade of joi from the current version will break compatibility with ES5.
https://github.com/hapijs/joi/commits/master?after=Y3Vyc29yOtCeNCeSeSsaqQE27cSdaZ5UG57jKzI0NA%3D%3D

Let's keep it as is for now, I'll mark it as next major (although I'm not sure if it will be the next one or the following one)

@ziluvatar ziluvatar mentioned this pull request Feb 22, 2017
Closed
@ziluvatar
Copy link
Copy Markdown
Contributor

ziluvatar commented Feb 22, 2017

Let's continue the possible conversation in this other PR (older) instead of having two PR for the same problem.

@ziluvatar ziluvatar closed this Feb 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

next-major

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wao813 @ziluvatar @zvictor