Skip to content

Upgrade joi to v10.1.0#292

Closed
0xchimz wants to merge 1 commit intoauth0:masterfrom
0xchimz:master
Closed

Upgrade joi to v10.1.0#292
0xchimz wants to merge 1 commit intoauth0:masterfrom
0xchimz:master

Conversation

@0xchimz
Copy link
Copy Markdown

@0xchimz 0xchimz commented Jan 5, 2017

Moment.js was removed from joi since v10.0.0 .... please remove "BIG" module from dependencies. 💃

@ziluvatar
Copy link
Copy Markdown
Contributor

Similar to #301

After a some investigation, any upgrade of joi from the current version will break compatibility with ES5.
https://github.com/hapijs/joi/commits/master?after=Y3Vyc29yOtCeNCeSeSsaqQE27cSdaZ5UG57jKzI0NA%3D%3D

Let's keep it as is for now, I'll mark it as next major (although I'm not sure if it will be the next one or the following one)

@ziluvatar
Copy link
Copy Markdown
Contributor

Closing this in favor of: #348

@ziluvatar ziluvatar closed this May 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants