add expiresInSeconds option to sign. closes #51

jfromaniello · jfromaniello · commit dd156cc30f17 · 2015-03-06T12:08:38.000-03:00
diff --git a/README.md b/README.md
@@ -25,7 +25,7 @@ encoded private key for RSA and ECDSA.
 `options`:
 
 * `algorithm` (default: `HS256`)
-* `expiresInMinutes`
+* `expiresInMinutes` or `expiresInSeconds`
 * `audience`
 * `subject`
 * `issuer`
diff --git a/index.js b/index.js
@@ -30,9 +30,12 @@ module.exports.sign = function(payload, secretOrPrivateKey, options) {
     payload.iat = timestamp;
   }
 
-  if (options.expiresInMinutes) {
-    var ms = options.expiresInMinutes * 60;
-    payload.exp = timestamp + ms;
+  var expiresInSeconds = options.expiresInMinutes ?
+      options.expiresInMinutes * 60 :
+      options.expiresInSeconds;
+
+  if (expiresInSeconds) {
+    payload.exp = timestamp + expiresInSeconds;
   }
 
   if (options.audience)
diff --git a/test/expiresInSeconds.tests.js b/test/expiresInSeconds.tests.js
@@ -0,0 +1,12 @@
+var jwt = require('../index');
+var expect = require('chai').expect;
+
+describe('noTimestamp', function() {
+
+  it('should work with string', function () {
+    var token = jwt.sign({foo: 123}, '123', { expiresInSeconds: 5 });
+    var result = jwt.verify(token, '123');
+    expect(result.exp).to.be.closeTo(Math.floor(Date.now() / 1000) + 5, 0.5);
+  });
+
+});

Original file line number	Diff line number	Diff line change
`@@ -30,9 +30,12 @@ module.exports.sign = function(payload, secretOrPrivateKey, options) {`
`30`	`30`	`payload.iat = timestamp;`
`31`	`31`	`}`
`32`	`32`
`33`		`- if (options.expiresInMinutes) {`
`34`		`- var ms = options.expiresInMinutes * 60;`
`35`		`- payload.exp = timestamp + ms;`
	`33`	`+ var expiresInSeconds = options.expiresInMinutes ?`
	`34`	`+ options.expiresInMinutes * 60 :`
	`35`	`+ options.expiresInSeconds;`
	`36`	`+`
	`37`	`+ if (expiresInSeconds) {`
	`38`	`+ payload.exp = timestamp + expiresInSeconds;`
`36`	`39`	`}`
`37`	`40`
`38`	`41`	`if (options.audience)`