add a console.warn on invalid options for string payloads

jfromaniello · jfromaniello · commit 71200f14deba · 2016-01-04T09:30:01.000-03:00
diff --git a/index.js b/index.js
@@ -38,15 +38,33 @@ JWT.decode = function (jwt, options) {
   return payload;
 };
 
+var payload_options = [
+  'expiresIn',
+  'notBefore',
+  'expiresInMinutes',
+  'expiresInSeconds',
+  'audience',
+  'issuer',
+  'subject',
+  'jwtid'
+];
+
 JWT.sign = function(payload, secretOrPrivateKey, options, callback) {
   options = options || {};
-  payload = typeof payload === 'object' ? xtend(payload) : payload;
   var header = {};
 
   if (typeof payload === 'object') {
     header.typ = 'JWT';
+    payload = xtend(payload);
+  } else {
+    var invalid_option = payload_options.filter(function (key) {
+      return typeof options[key] !== 'undefined';
+    })[0];
+
+    console.warn('invalid "' + invalid_option + '" option for ' + (typeof payload) + ' payload');
   }
 
+
   header.alg = options.algorithm || 'HS256';
 
   if (options.headers) {
diff --git a/test/non_object_values.tests.js b/test/non_object_values.tests.js
@@ -10,6 +10,13 @@ describe('non_object_values values', function() {
     expect(result).to.equal('hello');
   });
 
+  //v6 version will throw in this case:
+  it.skip('should throw with expiresIn', function () {
+    expect(function () {
+      jwt.sign('hello', '123', { expiresIn: '12h' });
+    }).to.throw(/invalid expiresIn option for string payload/);
+  });
+
   it('should fail to validate audience when the payload is string', function () {
     var token = jwt.sign('hello', '123');
     expect(function () {
