fix issue with buffer payload. closes #216

jfromaniello · jfromaniello · commit 6b50ff324b4d · 2016-07-15T09:32:35.000-03:00
diff --git a/sign.js b/sign.js
@@ -44,9 +44,12 @@ var options_for_objects = [
 module.exports = function (payload, secretOrPrivateKey, options, callback) {
   options = options || {};
 
+  var isObjectPayload = typeof payload === 'object' &&
+                        !Buffer.isBuffer(payload);
+
   var header = xtend({
     alg: options.algorithm || 'HS256',
-    typ: typeof payload === 'object' ? 'JWT' : undefined
+    typ: isObjectPayload ? 'JWT' : undefined
   }, options.header);
 
   function failure(err) {
@@ -56,17 +59,18 @@ module.exports = function (payload, secretOrPrivateKey, options, callback) {
     throw err;
   }
 
+
   if (typeof payload === 'undefined') {
     return failure(new Error('payload is required'));
-  } else if (typeof payload === 'object') {
+  } else if (isObjectPayload) {
     var payload_validation_result = registered_claims_schema.validate(payload);
 
     if (payload_validation_result.error) {
       return failure(payload_validation_result.error);
     }
 
     payload = xtend(payload);
-  } else if (typeof payload !== 'object') {
+  } else {
     var invalid_options = options_for_objects.filter(function (opt) {
       return typeof options[opt] !== 'undefined';
     });
diff --git a/test/buffer.tests.js b/test/buffer.tests.js
@@ -0,0 +1,10 @@
+var jwt = require("../.");
+var assert = require('chai').assert;
+
+describe('buffer payload', function () {
+  it('should work', function () {
+    var payload = new Buffer('TkJyotZe8NFpgdfnmgINqg==', 'base64');
+    var token = jwt.sign(payload, "signing key");
+    assert.equal(jwt.decode(token), payload.toString());
+  });
+});
