Throw proper exception from cached provider#169
Merged
jimmyjames merged 1 commit intomasterfrom Feb 3, 2023
Merged
Conversation
jimmyjames
commented
Feb 2, 2023
| return provider.get(keyId); | ||
| } | ||
| }); | ||
| return cache.get(cacheKey, () -> provider.get(keyId)); |
Contributor
Author
There was a problem hiding this comment.
change to lambda syntax, no functional change
Contributor
Author
|
codecov failure due to fall-thru line not being covered. Since |
Widcket
approved these changes
Feb 2, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this change, if using a cached JWK provider (the default), any exception caught when accessing the JWK would be a
SigningKeyNotFoundException, with a cause ofExecutionException(thrown by the cache provider).Since the cause of an exception may be for different reasons (e.g., network exception, KID not found), developers would need to unwrap the
SigningKeyNotFoundExceptionto get theExecutionException, which itself would contain the specific reason for failure (someJwkException).As raised in #165, this is cumbersome. Instead, this PR throws the causing exception directly, so that developers can more easily identify why the operation failed.
Fixes #165