Deprecation notice for secp256k1 curve in EC algorithm#528
Merged
Conversation
stevehobbsdev
previously approved these changes
Feb 18, 2022
stevehobbsdev
approved these changes
Feb 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Since Java 15, certain curves have been disabled. One of them is secp256k1 which has been mentioned in the README.
References
Java changelog - https://www.oracle.com/java/technologies/javase/15-relnote-issues.html#JDK-8237219
GH Issue #520
Testing
We tested the removal support using different java versions to test this.