Merged
Conversation
evansims
approved these changes
Sep 3, 2021
Merged
poovamraj
added a commit
that referenced
this pull request
Jan 12, 2022
poovamraj
added a commit
that referenced
this pull request
Jan 13, 2022
* Upgrade jackson dependency * Remove ignored files * Update baseline compare version to 3.18.2 as mentioned in PR #513
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
#288 changed the signature of
withIssuer(String issuer)towithIssuer(String... issuer). As discussed in #507, this is a binary incompatible change.This change restores that binary compatibility, by introducing a new default method on the
Verificationinterface, that simply delegates to the existing implementation.Notes:
apiDiffcheck to fail, as the japicmp gradle plugin does not currently support configuring this check (see Support for overrideCompatibilityChangeParameters melix/japicmp-gradle-plugin#43)Verificationinterface, which would then never catch any issues, we'll need to bump the baseline compare version when this change is released.JWTVerifierTestsalready contain a test that verify the behavior when callingwithIssuerwith a single string.CHANGELOGfor 3.8.0 to indicate the binary incompatible change, and note its fixed version.