Conversation
| def javaVersion = 8 | ||
| java { | ||
| toolchain { | ||
| languageVersion = JavaLanguageVersion.of(11) |
There was a problem hiding this comment.
Doesn't seem to be needed even when the library outputs a multi-jar with module support.
There was a problem hiding this comment.
@jimmyjames can you please double-check this one on your side? for me it keeps compiling after running something like ./gradlew clean build javadoc publishMavenJavaPublicationToMavenLocal --rerun-tasks
There was a problem hiding this comment.
Yes, if you are running gradle with java 11 it will work. Using a toolchain you should be able to run gradle with say, java 8, and gradle will use the specified toolchain version for tasks. However the custom compileModuleInfoJava task does not appear to be respecting the toolchain, instead using the java version running gradle. Since our CI runs on 11 and this issue exists outside this change, I'd at least add a comment to the custom task with a todo to use the toolchain version so we can run the build with a different java version.
There was a problem hiding this comment.
I tried changing my local JDK back to JDK 8 and ran the command above. The build is still successful. Do you think the comment is necessary? And, would that be for the "compileJava" task?
There was a problem hiding this comment.
Per our discussion today, I'll add this block back to prevent potential issues when running the build using JDK 8.
| def javaVersion = 8 | ||
| java { | ||
| toolchain { | ||
| languageVersion = JavaLanguageVersion.of(11) |
There was a problem hiding this comment.
Yes, if you are running gradle with java 11 it will work. Using a toolchain you should be able to run gradle with say, java 8, and gradle will use the specified toolchain version for tasks. However the custom compileModuleInfoJava task does not appear to be respecting the toolchain, instead using the java version running gradle. Since our CI runs on 11 and this issue exists outside this change, I'd at least add a comment to the custom task with a todo to use the toolchain version so we can run the build with a different java version.
2 participants
Changes
This PR updates the OSS release plugin version to 0.16.0, which makes use of a newer Javadoc HTML template.
I also removed the bintray plugin which is no longer used.