Move form commons-codec Base64 to j.u.Base64#478
Merged
jimmyjames merged 4 commits intoauth0:masterfrom Mar 8, 2021
Merged
Conversation
fix last usages of commons-codec Remove codec usages Remove commons-codec
Contributor
|
Thanks for making this PR. We'll be looking at this in more detail next week. |
jimmyjames
approved these changes
Mar 8, 2021
Contributor
jimmyjames
left a comment
jimmyjames
left a comment
There was a problem hiding this comment.
Thanks for the contribution; this looks good 👍 .
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Cherry picked 2 commits from this #401
3 tests broke, fixed them in a 3rd commit, so test change can be easier reviewed
References
#461
Testing
3 tests broke, so i fixed them and made separate commit with the fix, i can amend it if all ok
Checklist