-
Notifications
You must be signed in to change notification settings - Fork 948
3.8.0 introduced a breaking change #507
Copy link
Copy link
Closed
Labels
bugThis points to a verified bug in the codeThis points to a verified bug in the code
Description
Describe the problem
Version 3.8.0 of the library introduced a breaking change that broke binary compatibility. The method definition of com.auth0.jwt.interfaces.Verification.withAudience changed from (String) to (String[]) when the parameter was modified from being a regular String to using a varargs.
The breaking change is not documented.
What was the expected behavior?
Upgrading to a newer minor version of the library should not cause a breaking change in binary compatibility. Alternately, the breaking change should be documented.
The library should continue to have a proper withAudience(String) overload (or equivalent) to avoid the breaking change (assuming Java permits the overload alongside a varargs).
Reproduction
N/A. Breaking change can be seen in source for PR #246
Environment
- Version of this library used: 3.18.1 (upgrading from 3.3.0)
- Version of Java used: Java 8 (OpenJDK variant)
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugThis points to a verified bug in the codeThis points to a verified bug in the code