Add sessions and refresh tokens to Users Management API#661
Merged
Conversation
jimmyjames
requested changes
Sep 3, 2024
Contributor
There was a problem hiding this comment.
I added some comments; a few other things:
- Any reason to not also add support for the
/sessionsendpoints here? e.g., https://auth0.com/docs/api/management/v2/sessions/get-session. Or is that going to follow in a standalone PR? - It appears this branch is out-of-date with main and a CI check is failing, will need to update the branch with latest main and address CI failure.
Related to the /sessions endpoint, I believe the schema is the same for both /sessions and /users/{userId}/sessions. So we may want to consider where the new classes are packaged so they can be reused, maybe it makes sense to have a sessions package? Or maybe keeping them in users is ok, what do you think?
EDIT: One more question - have the new methods introduced here been tested against a live server to verify everything is working as expected?
src/main/java/com/auth0/client/mgmt/filter/CheckpointPaginationFilter.java
Outdated
Show resolved
Hide resolved
src/test/java/com/auth0/json/mgmt/users/refreshtokens/RefreshTokensPageTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/auth0/json/mgmt/users/refreshtokens/RefreshTokensPageTest.java
Outdated
Show resolved
Hide resolved
Contributor
Author
Earlier it was not added in JIRA, now I have added /sessions and /refresh-tokens API's in the same PR |
jimmyjames
requested changes
Sep 5, 2024
Contributor
jimmyjames
left a comment
jimmyjames
left a comment
There was a problem hiding this comment.
Looks good, just need some minor javadoc updates
jimmyjames
approved these changes
Sep 6, 2024
tanya732
changed the title
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Adds support for the following APIs:
https://auth0.com/docs/api/management/v2/users/get-refresh-tokens-for-user
https://auth0.com/docs/api/management/v2/users/delete-refresh-tokens-for-user
https://auth0.com/docs/api/management/v2/refresh-tokens/get-refresh-token
https://auth0.com/docs/api/management/v2/refresh-tokens/delete-refresh-token
https://auth0.com/docs/api/management/v2/users/get-sessions-for-user
https://auth0.com/docs/api/management/v2/users/delete-sessions-for-user
https://auth0.com/docs/api/management/v2/sessions/get-session
https://auth0.com/docs/api/management/v2/sessions/delete-session
Testing
Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.
Checklist