Add public User constructor without parameters#59
Merged
lbalmaceda merged 1 commit intomasterfrom Jun 22, 2017
Merged
Conversation
lbalmaceda
force-pushed
the
fix-user-constructor-visibility
branch
from
0962ccf to
30317aa
Compare
nikolaseu
approved these changes
Jun 21, 2017
.idea/kotlinc.xml
Outdated
| @@ -0,0 +1,7 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
Contributor
Author
There was a problem hiding this comment.
No. I guess because I have the Kotlin plugin installed it's adding this file to every project. Should I git-ignore it?
Contributor
There was a problem hiding this comment.
I don't know if it should be added to .gitignore, but at least remove it from this PR
lbalmaceda
force-pushed
the
fix-user-constructor-visibility
branch
from
30317aa to
695eb07
Compare
Contributor
Author
|
Amended. Removed the new |
nikolaseu
approved these changes
Jun 22, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User must have a connection when they are first created, but then if you want to change a property you must set a connection again (which cannot be changed). Related: #58 (comment)