Merged
Conversation
lbalmaceda
force-pushed
the
fix-query-encoding
branch
from
068924e to
330d972
Compare
hzalaz
approved these changes
May 23, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems that OkHttp it's not really URL encoding the query parameters, or that some chars are missing from that implementation, which affects both the
UsersEntity#listandLogsEntity#listmethods. This PR encodes the query value (and only that case) usingjava.net.URLEncoder. The client/entity later, only for that parameter, adds it to the request as a pre-encoded query parameter, in order to avoid OkHttp to encode again the%escaped chars.Personally I don't like being checking in the
forloop for a specific parameter name and adding it in a different way. Maybe it's better that the whole networking impl uses theURLEncoderfirst for all parameters and then adds them as "already encoded" to the request. Opinions?Fixes #54