Merged
Conversation
hamcrest-core now deprecated, just use the hamcrest lib.
stevehobbsdev
approved these changes
Jun 22, 2023
poovamraj
reviewed
Jun 22, 2023
Contributor
poovamraj
left a comment
poovamraj
left a comment
There was a problem hiding this comment.
Just a small comment on one of the tests
|
|
||
| @Test | ||
| public void maxRequestsPerHostMustBePositive() { | ||
| HttpOptions opts = new HttpOptions(); |
Contributor
There was a problem hiding this comment.
Guess this test misses a verify statement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🧪 Test only change 🧪
This change updates the JUnit dependency used to write and execute tests from JUnit 4 to JUnit 5.
Note for reviewers
This is a large PR that impacts every test class in the library 😅. There's not any test logic changes, however. The changes can be summarized as:
ExpectedExceptionRule in favor ofassertThrows. This is the bulk of the code changes.It may be useful to review by looking at the individual commits, which roughly correlate to the above changes.