[ESD-27129] authentication_methods is an object, not a string#520
Merged
jimmyjames merged 3 commits intomasterfrom Mar 29, 2023
Merged
[ESD-27129] authentication_methods is an object, not a string#520jimmyjames merged 3 commits intomasterfrom
jimmyjames merged 3 commits intomasterfrom
Conversation
ewanharris
approved these changes
Mar 28, 2023
poovamraj
approved these changes
Mar 28, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
The get authentication methods endpoint returns an
authentication_methodsfield, which is an array of objects. Prior to this PR, it was defined as an array of strings.References
ESD-27129
Testing
Updated the existing test json to reflect actual data shape from API call, and added a paged list result JSON as well.