Conversation
README.md
Outdated
|
|
||
| ### Renew Authentication | ||
|
|
||
| Creates a new request to renew the authentication and get fresh new credentials using a valid Refresh Token. |
There was a problem hiding this comment.
can I create something "old" ? xD just kidding, but the term "(re)new" is repeated several times, maybe we can remove the first
There was a problem hiding this comment.
do we need to specify like in ### Request Token for Audience - /oauth/token that this is the "new" /oauth/token refresh token?
lbalmaceda
force-pushed
the
add-refresh-token
branch
from
3b12e18 to
ad2f7c1
Compare
| @@ -35,6 +36,7 @@ public class AuthAPI { | |||
| private final String clientId; | |||
| private final String clientSecret; | |||
| private final String baseUrl; | |||
There was a problem hiding this comment.
do we still need this one?
There was a problem hiding this comment.
Not really, was used by the AuthorizeUrlBuilder but now that I see we can replace that parameter with the HttpUrl. Let me fix it. 👍
| if (baseUrl == null) { | ||
| throw new IllegalArgumentException("The domain had an invalid format and couldn't be parsed as an URL."); | ||
| } | ||
| this.httpUrl = HttpUrl.parse(baseUrl); |
There was a problem hiding this comment.
createBaseUrl already uses HttpUrl.parse, so maybe make that return that httpUrl directly?
then baseUrl (if really required) can be obtained from baseUrl = httpUrl.toString()
lbalmaceda
force-pushed
the
add-refresh-token
branch
from
263f93f to
d704ce8
Compare
|
Looks good |
lbalmaceda
force-pushed
the
add-refresh-token
branch
from
d704ce8 to
d960564
Compare
lbalmaceda
force-pushed
the
add-refresh-token
branch
from
d960564 to
9d56b38
Compare
2 participants
Renew the authentication using a
refresh_token.Closes #48