[SDK-3924] Add support for Authentication methods API#506
Merged
Conversation
jimmyjames
requested changes
Jan 19, 2023
Contributor
jimmyjames
left a comment
jimmyjames
left a comment
There was a problem hiding this comment.
Looks good generally, just a couple minor comments, and need to get the build/tests passing.
|
|
||
| @JsonIgnoreProperties(ignoreUnknown = true) | ||
| @JsonInclude(JsonInclude.Include.NON_NULL) | ||
| public class AuthenticationMethod implements Serializable { |
Contributor
There was a problem hiding this comment.
no need to implement Serializable. Looks like we have it in some old classes but is not needed.
| @@ -0,0 +1,247 @@ | |||
| package com.auth0.json.mgmt.authenticationmethods; | |||
Contributor
There was a problem hiding this comment.
I think these classes should go in the json.mgmt.users package, unless used outside of the UsersEntity.
jimmyjames
approved these changes
Jan 20, 2023
This was referenced Jan 26, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This change adds support for the following Authenticator Methods APIs to the UserEntity client:
References
#504
Testing
Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.