Conversation
| * } | ||
| * </pre> | ||
| * | ||
| * @param refreshToken the refresh token to revoke. |
There was a problem hiding this comment.
you can't configure anything right?
There was a problem hiding this comment.
Nice catch. I'll update it.
| */ | ||
| public Request<Void> revokeToken(String refreshToken) { | ||
| Asserts.assertNotNull(refreshToken, "refresh token"); | ||
|
|
There was a problem hiding this comment.
totally unrelated: wasn't this repo that I made a PR to avoid having to parse each time? also this can fail, so it's better to fail fast, right in the constructor..
There was a problem hiding this comment.
Yes, but you did that just for the Management API. It can be done in a separate PR to keep small the diff.
| .build() | ||
| .toString(); | ||
| VoidRequest request = new VoidRequest(client, url, "POST"); | ||
| request.addParameter(KEY_CLIENT_ID, clientId); |
There was a problem hiding this comment.
I think you can revoke refresh tokens without client secret, but this is already required so we have it anyway, right?
There was a problem hiding this comment.
... the
/oauth/revokeendpoint supports passing noclient_secretbut the client itself must have the propertytokenEndpointAuthMethodset tonone...
2 participants
No description provided.