Fix double-encoding of log event filter query param#420
Merged
jimmyjames merged 3 commits intomasterfrom Apr 12, 2022
Merged
Conversation
jimmyjames
changed the title
Contributor
Author
|
I can only assume that the codecov project check is failing (down 0.01% for project) due to the minor refactoring to reuse common code. Given it's a one-one hundredth of a percent change, and we have a test case that fails without this fix, I'm not going to chase the codecov check. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Log event filter query params are being double-encoded as demonstrated in #419. This change doesn't double-encode the filter query, similar to how we do not encode it in
UsersEntity#list.