[SDK-3098] Fix documentation for authorize and logout URL creation#406
Merged
jimmyjames merged 1 commit intomasterfrom Feb 17, 2022
Merged
[SDK-3098] Fix documentation for authorize and logout URL creation#406jimmyjames merged 1 commit intomasterfrom
jimmyjames merged 1 commit intomasterfrom
Conversation
adamjmcgrath
approved these changes
Feb 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #390, the documentation for generating the authorize (and logout) URLs is wrong. The docs state that the URLs should be encoded, though the validation will fail when it is encoded.
We may make a change to encode the redirect/returnTo URLs, but that may need to go into the next major release to avoid any unintended consequences of changing the current behavior.