Support maxRequests and maxRequestsPerHost client confiugrations#402
Merged
jimmyjames merged 1 commit intomasterfrom Feb 1, 2022
Merged
Support maxRequests and maxRequestsPerHost client confiugrations#402jimmyjames merged 1 commit intomasterfrom
jimmyjames merged 1 commit intomasterfrom
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change exposes to new networking client configuration points on the
HttpOptionsclass:setMaxRequests(int maxRequests), which defines the maximum requests that can be execute concurrentlysetMaxRequestsPerHost(int max), which defines the maximum requests that can be executed per host.These configurations just delegate to their respective configurations on OkHttp's
Dispatcher.(Note: While these changes are pretty simple to make, as a common configuration point we should consider supporting a pluggable http client later in the next major version of this library)