Improve Guardian section#39
Merged
lbalmaceda merged 5 commits intoauth0:masterfrom Mar 14, 2017
nikolaseu:chore-improve-guardian-section
Merged
Improve Guardian section#39lbalmaceda merged 5 commits intoauth0:masterfrom nikolaseu:chore-improve-guardian-section
lbalmaceda merged 5 commits intoauth0:masterfrom
nikolaseu:chore-improve-guardian-section
Conversation
lbalmaceda
suggested changes
Feb 22, 2017
| provider.setAuthToken("atokEn"); | ||
| provider.setFrom("+12356789"); | ||
| provider.setMessagingServiceSID("id321"); | ||
| provider.setSID("id123"); |
Contributor
There was a problem hiding this comment.
We should still test that the deprecated methods behave as we expect.
| provider.setAWSAccessKeyId("akey"); | ||
| provider.setAWSSecretAccessKey("secretakey"); | ||
| provider.setSNSAPNSPlatformApplicationARN("arn1"); | ||
| provider.setSNSGCMPlatformApplicationARN("arn2"); |
Contributor
There was a problem hiding this comment.
We should still test that the deprecated methods behave as we expect.
lbalmaceda
reviewed
Mar 13, 2017
| @JsonProperty("messaging_service_sid") | ||
| public void setMessagingServiceSID(String messagingServiceSID) { | ||
| public void setMessagingServiceSID(String messagingServiceSID) throws IllegalArgumentException { | ||
| if (from != null) { |
Contributor
There was a problem hiding this comment.
If the user is removing the messagingServiceSID i.e. setting messagingServiceSID=null then the exception will be thrown anyway. The check should be:
if (from!=null && messagingServiceSID!=null){
//..
}| @JsonProperty("from") | ||
| public void setFrom(String from) { | ||
| public void setFrom(String from) throws IllegalArgumentException { | ||
| if (messagingServiceSID != null) { |
Contributor
There was a problem hiding this comment.
If the user is removing the from i.e. setting from=null then the exception will be thrown anyway. The check should be:
if (from!=null && messagingServiceSID!=null){
//..
}
…ServiceSid" specified but not both
lbalmaceda
approved these changes
Mar 14, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.