[SDK-2686] Add retry on rate limit errors for management API#368
Merged
jimmyjames merged 1 commit intomasterfrom Aug 19, 2021
Merged
[SDK-2686] Add retry on rate limit errors for management API#368jimmyjames merged 1 commit intomasterfrom
jimmyjames merged 1 commit intomasterfrom
Conversation
evansims
approved these changes
Aug 13, 2021
Contributor
evansims
left a comment
evansims
left a comment
There was a problem hiding this comment.
LGTM! Awesome work on this 👍
Contributor
Author
|
@lbalmaceda can you please have a look at this as well? Thanks! |
|
Awesome work, please notify me when this version is available on maven |
Contributor
Author
|
Will do @shoikot, we may have some other changes to include in the next release, so it may be next week 👍 |
Merged
Contributor
Author
|
@shoikot this is available in maven central now, v1.34.0. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This change adds the ability to retry requests to the Management API that fail due to a rate-limit (429) error. It does so through a new OkHttp Interceptor and the failsafe library.
Details:
HttpOptionsobject. If/when retries are applied to authentication requests, a similar configuration point will be added for clients to be able to independently configure the maximum retries.