Skip to content

Deprecate unused constructors in Page implementations#363

Merged
jimmyjames merged 1 commit intomasterfrom
deprecate-old-constructors
Jul 26, 2021
Merged

Deprecate unused constructors in Page implementations#363
jimmyjames merged 1 commit intomasterfrom
deprecate-old-constructors

Conversation

@jimmyjames
Copy link
Copy Markdown
Contributor

Changes

As part of #362, new constructors were added to response types that may included checkpoint paginated responses. Per the discussion on that PR, it was recommended that these constructors be deprecated to signal the (internal) usage should prefer construction that can accept the next field for paginated responses.

@jimmyjames jimmyjames added this to the v1-Next milestone Jul 26, 2021
@jimmyjames jimmyjames requested a review from a team as a code owner July 26, 2021 18:21
Copy link
Copy Markdown
Contributor

@evansims evansims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jimmyjames jimmyjames merged commit 6c9e398 into master Jul 26, 2021
@jimmyjames jimmyjames modified the milestones: v1-Next, 1.33.0 Jul 26, 2021
@jimmyjames jimmyjames mentioned this pull request Jul 26, 2021
@jimmyjames jimmyjames deleted the deprecate-old-constructors branch August 10, 2021 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants