[SDK-2622] Add expiresAt to token response#357
Merged
jimmyjames merged 7 commits intomasterfrom Jul 1, 2021
Merged
Conversation
jimmyjames
commented
Jun 24, 2021
jimmyjames
commented
Jun 24, 2021
jimmyjames
commented
Jun 24, 2021
lbalmaceda
suggested changes
Jun 28, 2021
…res_in not provided
lbalmaceda
approved these changes
Jun 29, 2021
pennstatephil
approved these changes
Jun 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
The response from
/oauth/tokenincludes anexpires_infield, which is the time (from issuance) that the access token expires in. As noted in #356, customers wishing to know the expiry status of the token need to manage this manually, by calculating the expiry time from the issuance andexpires_invalue. This change introduces a new calculated value toTokenHolderthat represents the expiration time of the access token.Reviewer notes
Datetype was used for the newexpiresAtfield, to provide consistency with other types (customers can useDate.from(Instant value)to take advantage of modern date/time APIs, as the unit tests demonstrate)