Add support for organizations feature#338
Merged
jimmyjames merged 2 commits intomasterfrom Mar 25, 2021
Merged
Conversation
frederikprijck
requested changes
Mar 24, 2021
| .build() | ||
| .verify(jwt); | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
Should we also add the following two tests:
- fails when an organization is provided to the IdTokenValidator but no claim was found
- Doesn't fail when no organization is provided to IdTokenValidator but the token has an org_id claim
Contributor
Author
There was a problem hiding this comment.
Yes, those are good tests to add, will push a new commit shortly.
Contributor
Author
There was a problem hiding this comment.
Additional tests to cover those scenarios pushed, good catch!
lbalmaceda
reviewed
Mar 24, 2021
frederikprijck
approved these changes
Mar 25, 2021
This was referenced Mar 25, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR adds support for the (beta) Organizations and User Invitations features. Changes included:
organizationandinvitationquery parameters when building the Authorization URLorg_idclaim inIdTokenVerifierTesting
In addition to unit tests, the change was tested using an application and tenant with the Organizations feature enabled. I verified that with this change it adds the organization and invitation query parameters to the authorization URL to enable login/joining an organization.
Checklist