Update README for Spring Boot dependency collisions#336
Merged
jimmyjames merged 1 commit intomasterfrom Mar 8, 2021
Merged
Conversation
jimmyjames
added
documentation
evansims
approved these changes
Mar 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Spring's dependency management defines okhttp v3 as part of its exported BOM, which collides with okhttp v4 used by this library. This results in
java.lang.NoSuchMethodErrorwhen making requests, as reported in #324. Unfortunately we cannot control how Spring exports its dependencies, so this PR updates the README to include the workaround of specifying okhttp v4 in the spring dependency management configuration.References
Testing
Solution tested by creating both a maven and gradle project using the spring boot plugins. Without the bom override,
NoSuchMethodErrorobserved when making requests. With the bom override, the error is resolved.Checklist