Skip to content

Add methods to determine cause of APIException#310

Merged
jimmyjames merged 3 commits intomasterfrom
apiException-types
Oct 28, 2020
Merged

Add methods to determine cause of APIException#310
jimmyjames merged 3 commits intomasterfrom
apiException-types

Conversation

@jimmyjames
Copy link
Copy Markdown
Contributor

Changes

Resolves #279.

Adds methods to APIException to help determine the cause of the underlying APIException, similar to how Auth0.Android handles this. Other methods can be added in the future as needed.

References

Testing

There is no existing test for APIException; this change adds a test class but only adds tests for the added functionality.

  • This change adds test coverage
  • This change has been tested on the latest version of the platform/language or why not

Checklist

@jimmyjames jimmyjames added this to the v1-Next milestone Oct 27, 2020
@jimmyjames jimmyjames requested a review from a team as a code owner October 27, 2020 22:11
lbalmaceda
lbalmaceda previously approved these changes Oct 27, 2020
Copy link
Copy Markdown
Contributor

@lbalmaceda lbalmaceda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one comment, not a blocker

@lbalmaceda lbalmaceda self-requested a review October 28, 2020 20:36
@jimmyjames jimmyjames merged commit a2050e4 into master Oct 28, 2020
@jimmyjames jimmyjames modified the milestones: v1-Next, 1.24.0 Nov 2, 2020
@jimmyjames jimmyjames mentioned this pull request Nov 2, 2020
3 tasks
@evansims evansims deleted the apiException-types branch July 5, 2022 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Custom Exception for MFA challenge on login [SDK-1998]

2 participants