Return TokenRequest instead of AuthRequest#309
Merged
jimmyjames merged 3 commits intomasterfrom Oct 30, 2020
Merged
Conversation
lbalmaceda
approved these changes
Oct 30, 2020
|
This is a breaking change.. Why this was released under a minor change? FYI https://semver.org |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Resolves #307. See issue and comments for reasonings and alternatives.
References
auth0-forwarded-forheader to the AuthApi.login methods #302Testing
Added a test for verifying that custom headers can be added to one of the
loginmethods, to verify that the issue reported originally in #302 will be resolved with this change. Kept other tests expecting anAuthRequest(sinceTokenRequestis aAuthRequest, and it ensures that the change is backwards-compatible.Checklist