Skip to content

Add support for MFA OTP exchange#303

Merged
jimmyjames merged 4 commits intomasterfrom
exchange-mfa-otp
Oct 21, 2020
Merged

Add support for MFA OTP exchange#303
jimmyjames merged 4 commits intomasterfrom
exchange-mfa-otp

Conversation

@jimmyjames
Copy link
Copy Markdown
Contributor

Changes

Fixes #280 and supersedes work started in #281.

Adds a new public API to exchange an MFA one-time password (OTP) for a set of tokens:

public AuthRequest exchangeMfaOtp(String mfaToken, char[] otp)

References

Testing

  • This change adds test coverage
  • This change has been tested on the latest version of the platform/language or why not

Checklist

@jimmyjames jimmyjames added this to the v1-Next milestone Oct 21, 2020
@jimmyjames jimmyjames requested a review from a team October 21, 2020 14:15
lbalmaceda
lbalmaceda previously approved these changes Oct 21, 2020
Copy link
Copy Markdown
Contributor

@lbalmaceda lbalmaceda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: Luciano Balmaceda <[email protected]>
lbalmaceda
lbalmaceda previously approved these changes Oct 21, 2020
lbalmaceda
lbalmaceda previously approved these changes Oct 21, 2020
@jimmyjames jimmyjames merged commit 6496121 into master Oct 21, 2020
@jimmyjames jimmyjames deleted the exchange-mfa-otp branch October 22, 2020 13:46
@jimmyjames jimmyjames modified the milestones: v1-Next, 1.23.0 Oct 22, 2020
@jimmyjames jimmyjames mentioned this pull request Oct 22, 2020
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add MFA login to library - [SDK-1997]

2 participants