Add missing Linking User Accounts endpoint#270
Merged
lbalmaceda merged 4 commits intoauth0:masterfrom Jul 27, 2020
cschwalm:feature/269_link_with
Merged
Add missing Linking User Accounts endpoint#270lbalmaceda merged 4 commits intoauth0:masterfrom cschwalm:feature/269_link_with
lbalmaceda merged 4 commits intoauth0:masterfrom
cschwalm:feature/269_link_with
Conversation
… (link_with) The Java Auth0 API is missing the ability to link accounts using the "link_with" body parameter option. This is useful for when the client sends the secondary ID token to link with. Override the linkIdentity method in UsersEntity.java to support the ability to supply a ID token instead of a connection and provider string. See: https://auth0.com/docs/api/management/v2#!/Users/post_identities
lbalmaceda
suggested changes
Jun 19, 2020
Contributor
lbalmaceda
left a comment
lbalmaceda
left a comment
There was a problem hiding this comment.
A few docs/tests changes. The rest looks fine. Thanks for this!
… (link_with) Modified JavaDoc to include additional clarity to when secondary token linking can be used. Added additional unit test.
lbalmaceda
suggested changes
Jun 22, 2020
lbalmaceda
approved these changes
Jul 27, 2020
lbalmaceda
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
The Java Auth0 API is missing the ability to link accounts using the "link_with" body parameter option. This is useful for when the client sends the secondary ID token to link with.
Override the linkIdentity method in UsersEntity.java to support the ability to supply a ID token instead of a connection and provider string.
References
#269
See: https://auth0.com/docs/api/management/v2#!/Users/post_identities
Testing
Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.
Checklist