Make CreatedUser take the id from different properties#245
Merged
lbalmaceda merged 1 commit intomasterfrom Apr 13, 2020
Merged
Conversation
jimmyjames
approved these changes
Apr 10, 2020
Contributor
jimmyjames
left a comment
jimmyjames
left a comment
There was a problem hiding this comment.
👍 for adding tests around CreatedUser!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
When a new user is created via the signup endpoint, the user id value could be returned in different properties, depending on the connection where this user was created on. The properties include
_id(default),id(custom DB connections), anduser_id(custom external DB connections).Luckily, this was easy to solve using Jackson annotations for providing alternative aliases.
References
Fixes #176.
Testing
Tests were added to ensure there was no introduced breaking change in behavior.
Checklist