Skip to content

Add getter for DeviceCredentials client_id#215

Merged
lbalmaceda merged 1 commit intomasterfrom
add-dev-cred-getter
Jun 27, 2019
Merged

Add getter for DeviceCredentials client_id#215
lbalmaceda merged 1 commit intomasterfrom
add-dev-cred-getter

Conversation

@lbalmaceda
Copy link
Copy Markdown
Contributor

@lbalmaceda lbalmaceda commented Jun 27, 2019 •
edited
Loading

Changes

This client_id getter was missing from DeviceCredentials

Testing

  • This change adds test coverage
  • This change has been tested on the latest version of the platform/language or why not

Checklist

@lbalmaceda lbalmaceda requested a review from a team June 27, 2019 20:21
@lbalmaceda lbalmaceda added this to the v1-Next milestone Jun 27, 2019
damieng
damieng suggested changes Jun 27, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@damieng damieng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rebase this against master so the resource server changes aren't in it?

@lbalmaceda lbalmaceda changed the title Add setter for DeviceCredentials client_id Add getter for DeviceCredentials client_id Jun 27, 2019
@lbalmaceda lbalmaceda force-pushed the add-dev-cred-getter branch from cb1d877 to 25ff181 Compare June 27, 2019 21:09
@lbalmaceda lbalmaceda merged commit 822d9ee into master Jun 27, 2019
@lbalmaceda lbalmaceda deleted the add-dev-cred-getter branch June 27, 2019 21:53
@lbalmaceda lbalmaceda modified the milestones: v1-Next, 1.14.0 Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@damieng damieng damieng approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CH: Added small

Projects

None yet

Milestone

1.14.0

Development

Successfully merging this pull request may close these issues.

2 participants

@lbalmaceda @damieng