Skip to content

Add missing metadata field to Connection object#206

Merged
lbalmaceda merged 1 commit intoauth0:masterfrom
AlisonT1230:Connection-metadata
May 9, 2019
Merged

Add missing metadata field to Connection object#206
lbalmaceda merged 1 commit intoauth0:masterfrom
AlisonT1230:Connection-metadata

Conversation

@AlisonT1230
Copy link
Copy Markdown

Pull request for issue #205

  • Modified Connection class to contain a new metadata field
  • Added sample metadata to existing test case with Connection object
  • Added sample metadata to existing MockServer test resource file

@AlisonT1230 AlisonT1230 marked this pull request as ready for review May 9, 2019 20:19
@AlisonT1230 AlisonT1230 requested a review from a team May 9, 2019 20:19
Copy link
Copy Markdown
Contributor

@lbalmaceda lbalmaceda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lbalmaceda lbalmaceda added this to the v1-Next milestone May 9, 2019
@lbalmaceda lbalmaceda merged commit 246c34e into auth0:master May 9, 2019
@AlisonT1230 AlisonT1230 deleted the Connection-metadata branch May 9, 2019 21:32
@lbalmaceda lbalmaceda changed the title Add metadata field to Connection object Add missing metadata field to Connection object May 22, 2019
@lbalmaceda lbalmaceda modified the milestones: v1-Next, 1.13.3 May 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants