Remove default version for search_engine#194
Merged
Conversation
joshcanhelp
approved these changes
Apr 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This SDK was hardcoding the
search_enginetov2by default. This version was deprecated on June and is no longer available since November 13th 2018. This PR removes the default value in order to make use of the server's default (latest). Currently, this version isv3.If this change is not introduced and users do not set explicitly a version e.g. v3, then requests would fail with an "invalid search_engine version" message.
We encourage the users to migrate to the latest version by following the guide here.
References
Testing
Checklist