Skip to content

Add support for Core Authorization's User Roles and Permissions#193

Merged
lbalmaceda merged 11 commits intoauth0:masterfrom
jakbutler:feature/core-authorization-support
Apr 23, 2019
Merged

Add support for Core Authorization's User Roles and Permissions#193
lbalmaceda merged 11 commits intoauth0:masterfrom
jakbutler:feature/core-authorization-support

Conversation

@jakbutler
Copy link
Copy Markdown
Contributor

@jakbutler jakbutler commented Mar 26, 2019 •
edited
Loading

Changes

  • Added a new RolesEntity for providing access to the Role management API endpoints.
  • Added supporting Role, Permission, RolesPage, and PermissionPage value objects, with respective deserializers.
  • Added a RolesFilter for use in the get_roles call.
  • Added a simple PageFilter for specifying filter objects that only contain pagination options, e.g. per_page and include_totals.
  • Updated UserEntity to include User Permission and User Role endpoints.

References

Feature Request #192

Testing

  • This change adds test coverage
  • This change has been tested on the latest version of the platform/language

Checklist

@lbalmaceda
Copy link
Copy Markdown
Contributor

lbalmaceda commented Mar 26, 2019

@jakbutler thanks for taking care of this. I've added a review task to the backlog and I hope I can start with it the next week.

@jakbutler jakbutler force-pushed the feature/core-authorization-support branch from be4f113 to eddfd60 Compare March 28, 2019 15:38
@jakbutler
Copy link
Copy Markdown
Contributor Author

jakbutler commented Mar 28, 2019

Apologies, I'd forgotten to also update the README.md to mention the Roles entity; that's been added now.

@martijnblankestijn
Copy link
Copy Markdown

martijnblankestijn commented Apr 5, 2019

Terrific work @jakbutler ! I was just researching how we could use the Roles API and found out it was missing. A very nice surprise to see this PR. I can't wait until a new release is being made with this feature added. I

lbalmaceda
lbalmaceda suggested changes Apr 17, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@lbalmaceda lbalmaceda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! 🎉
I've left some comments. Some of them are repetitive, e.g. wrong formatting of java docs, methods to request all items vs paginated, etc. Know I've skipped reviewing tests and json files for now. This is a first pass. You'll probably end up deleting 1/4 of the diff introduced. I'll hold to that for completing the review 👍

jakbutler pushed a commit to jakbutler/auth0-java that referenced this pull request Apr 17, 2019
@cs-jackb
Implemented feedback from PR auth0#193
d788ab1
@jakbutler jakbutler force-pushed the feature/core-authorization-support branch from d788ab1 to 107ca68 Compare April 17, 2019 22:25
@jakbutler jakbutler force-pushed the feature/core-authorization-support branch from 376af32 to ca2877c Compare April 17, 2019 22:46
@jakbutler jakbutler force-pushed the feature/core-authorization-support branch from e3f5be8 to 487f665 Compare April 23, 2019 14:27
lbalmaceda
lbalmaceda approved these changes Apr 23, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@lbalmaceda lbalmaceda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lbalmaceda lbalmaceda added this to the v1-Next milestone Apr 23, 2019
@lbalmaceda lbalmaceda changed the title Issue #192: Support for Core Authorization's User Roles and Permissions Add support for Core Authorization's User Roles and Permissions Apr 23, 2019
@lbalmaceda lbalmaceda merged commit d3c24db into auth0:master Apr 23, 2019
@lbalmaceda lbalmaceda modified the milestones: v1-Next, 1.13.0 Apr 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@lbalmaceda lbalmaceda lbalmaceda approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CH: Added

Projects

None yet

Milestone

1.13.0

Development

Successfully merging this pull request may close these issues.

4 participants

@jakbutler @lbalmaceda @martijnblankestijn @cs-jackb