Add "mark_email_as_verified" property to PasswordChangeTicket#189
Merged
lbalmaceda merged 2 commits intomasterfrom Mar 11, 2019
unknown repository
Merged
Add "mark_email_as_verified" property to PasswordChangeTicket#189lbalmaceda merged 2 commits intomasterfrom unknown repository
lbalmaceda merged 2 commits intomasterfrom
unknown repository
Conversation
lbalmaceda
suggested changes
Mar 7, 2019
Contributor
lbalmaceda
left a comment
There was a problem hiding this comment.
A single change and I'll merge it. Tests are fine already 👍
src/main/java/com/auth0/json/mgmt/tickets/PasswordChangeTicket.java
Outdated
Show resolved
Hide resolved
…n PasswordChangeTicket's setter
Author
|
@lbalmaceda thanks a lot for your review. When could we expect this change to be released? |
lbalmaceda
approved these changes
Mar 11, 2019
Contributor
|
By eow at the most. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Auth0 Team,
according to the Management API v2 documentation, /password-change endpoint accepts a new extra parameter, namely mark_email_as_verified. The current version of auth0-java client API is missing this feature.
We would like to utilize this feature in our service and use the official client library.
Thank you in advance.
Best regards,
Yevhenii.
Changes
A new field has been added to the class definition and a corresponding unit test has been updated.
References
Management API v2: Create a password change ticket
Testing
Although the change is really small and is covered by a test, I performed a small local test and creating a password change ticket using the patched auth0-java library:
Checklist