Add test case for PasswordChangeTicket with Email#187
Merged
lbalmaceda merged 2 commits intoauth0:masterfrom Apr 23, 2019
Merged
Add test case for PasswordChangeTicket with Email#187lbalmaceda merged 2 commits intoauth0:masterfrom
lbalmaceda merged 2 commits intoauth0:masterfrom
Conversation
Improved unit test coverage, and added a unit test for covering the case of creating a PasswordChangeTicket using an email and custom connection as parameters. Improved from 73% to 93%.
lbalmaceda
approved these changes
Feb 11, 2019
Contributor
lbalmaceda
left a comment
lbalmaceda
left a comment
There was a problem hiding this comment.
I think that only invoking the other constructor would be enough for the coverage to go up to 100%, since the rest of the setters are called in the test right above it. But it's no harm to duplicate those other checks. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improved unit test coverage, and added a unit test for covering the case of creating a PasswordChangeTicket using an email and custom connection as parameters.
Improved from 70% to 100
%.