Skip to content

Add web_origins attribute to the Client class#148

Merged
lbalmaceda merged 2 commits intomasterfrom
web-origins
Sep 25, 2018
Merged

Add web_origins attribute to the Client class#148
lbalmaceda merged 2 commits intomasterfrom
web-origins

Conversation

@lbalmaceda
Copy link
Copy Markdown
Contributor

This attribute was missing from the SDK. Added to the Auth0 MGMT API on the CORS auth update.

@lbalmaceda lbalmaceda added this to the v1-Next milestone Sep 5, 2018
Copy link
Copy Markdown
Member

@cocojoe cocojoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

assertThat(client.isOIDCConformant(), is(true));

assertThat(client.getCallbacks(), contains("value"));
assertThat(client.getWebOrigins(), contains("value"));
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like they are all value but it's okay for this.

@lbalmaceda lbalmaceda merged commit 1bbdbcf into master Sep 25, 2018
@lbalmaceda lbalmaceda deleted the web-origins branch September 25, 2018 13:47
@lbalmaceda lbalmaceda modified the milestones: v1-Next, 1.9.0 Sep 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants