Application (aka Client) description field support#147
Merged
lbalmaceda merged 3 commits intoauth0:masterfrom Aug 30, 2018
Merged
Application (aka Client) description field support#147lbalmaceda merged 3 commits intoauth0:masterfrom
lbalmaceda merged 3 commits intoauth0:masterfrom
Conversation
lbalmaceda
suggested changes
Aug 21, 2018
Contributor
lbalmaceda
left a comment
lbalmaceda
left a comment
There was a problem hiding this comment.
Thanks! I've added a small comment
src/test/resources/mgmt/client.json
Outdated
| @@ -1,5 +1,6 @@ | |||
| { | |||
| "name": "My 1 application", | |||
| "description": "My 1 application", | |||
Contributor
There was a problem hiding this comment.
There's no reason to change this JSON files content unless you're going to test them. If so, please use a different string that the one used for the name. This applies to the other file as well.
Contributor
Author
|
Thanks for the review @lbalmaceda, I've reverted back the JSON files changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
That is improvement for the issue #146.
The changes contain:
descriptionfield support in theClientobjectPlease, let me know if some additional changes are required in case I missed anything.
Thanks,
Roman